-
Notifications
You must be signed in to change notification settings - Fork 355
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: modify the cmd help message #2128
Conversation
f2bff11
to
32d4553
Compare
Codecov ReportPatch coverage has no change and project coverage change:
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more Additional details and impacted files@@ Coverage Diff @@
## main #2128 +/- ##
=========================================
+ Coverage 8.38% 12.73% +4.35%
=========================================
Files 258 258
Lines 22194 22198 +4
=========================================
+ Hits 1860 2827 +967
+ Misses 20088 18990 -1098
- Partials 246 381 +135
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 28 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
cmd/sealer/cmd/alpha/gen.go
Outdated
@@ -43,7 +43,7 @@ Then you can use any sealer command to manage the cluster like: | |||
|
|||
var exampleForGenCmd = `The following command will generate Clusterfile used by sealer under user home dir: | |||
|
|||
sealer alpha gen --passwd Sealer123 --image kubernetes:v1.19.8 | |||
sealer alpha gen --passwd 'Sealer123' --image kubernetes:v1.19.8 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
--image kubernetes:v1.19.8
replace to the latest sealer image version Or give a sample .
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
76467e2
to
ba1385a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Describe what this PR does / why we need it
Use single quotes around the password to ensure that the password is treated as a string.
example:
sealer run docker.io/sealerio/kubernetes:v1.22.15 -m 172.16.130.20 -n 172.16.130.21 -p 'Sealer123$abc'
Does this pull request fix one issue?
Describe how you did it
Describe how to verify it
Special notes for reviews