Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: using a new progress bar SDK to sealer scp #2136

Merged
merged 1 commit into from
Mar 28, 2023

Conversation

Lan-ce-lot
Copy link
Contributor

Describe what this PR does / why we need it

Does this pull request fix one issue?

Fixes #2052

Describe how you did it

Use progress bar sdk "https://github.com/schollz/progressbar" to sealer scp.
from
image
to
image

Describe how to verify it

Special notes for reviews

@codecov-commenter
Copy link

codecov-commenter commented Mar 23, 2023

Codecov Report

Patch coverage has no change and project coverage change: -5.74 ⚠️

Comparison is base (70a4c9f) 18.82% compared to head (1885b96) 13.09%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2136      +/-   ##
==========================================
- Coverage   18.82%   13.09%   -5.74%     
==========================================
  Files          96      259     +163     
  Lines        8950    22228   +13278     
==========================================
+ Hits         1685     2911    +1226     
- Misses       7035    18931   +11896     
- Partials      230      386     +156     
Flag Coverage Δ
e2e-tests 9.21% <ø> (?)
unit-tests 18.89% <0.00%> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
utils/ssh/scp.go 0.00% <0.00%> (ø)
utils/ssh/utils.go 0.00% <ø> (ø)

... and 163 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Lan-ce-lot Lan-ce-lot changed the title feat: using a new progress bar SDK to sealer scp refactor: using a new progress bar SDK to sealer scp Mar 23, 2023
@kakaZhou719
Copy link
Member

@Lan-ce-lot ,thanks for your work. i am ok with this style progress bar. while i thought, could we move out the code for this progress bar to a separate package? such like utils/progressbar?

@Lan-ce-lot Lan-ce-lot force-pushed the progress-bar branch 2 times, most recently from ceaacd1 to 0708c17 Compare March 28, 2023 03:18
Signed-off-by: Lancelot <1984737645@qq.com>
@Lan-ce-lot
Copy link
Contributor Author

Ok.

Copy link
Member

@kakaZhou719 kakaZhou719 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[help wanted] using a new progress bar SDK to sealer scp
3 participants