Add NewProcessorsAndRun test
#2158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/cc @starnop @kakaZhou719 |
kakaZhou719
reviewed
Mar 31, 2023
|
hi, @amirrmonfared ,thanks for your contribution , agree with you that we should add this UT test to improve sealer test coverage. |
Hi @kakaZhou719 thanks for your time on review my PR, I will try to contribute more and increase the unit test coverage! |
Signed-off-by: amirrmonfared <amir.monfared@ginbits.com>
amirrmonfared
force-pushed
the
add-new-processor-test
branch
from
a4f28a8
to
22ba62a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe what this PR does / why we need it
Regarding test coverage, we should un-comment those tests which we commented on during development to ensure we have good quality of code
Does this pull request fix one issue?
NONE
Describe how you did it
by using base64 package to encode the exact string
Describe how to verify it
run test please.
Signed-off-by: amirrmonfared amir.monfared@ginbits.com