Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: use registered app name as final app name list #2167

Conversation

kakaZhou719
Copy link
Member

@kakaZhou719 kakaZhou719 commented Apr 4, 2023

Describe what this PR does / why we need it

Kuebfile:

FROM scratch
APP app1 local://app1.yaml
APP app2 local://app2.yaml
APP app3 local://app3.yaml
LAUNCH ["app1","app2"]
apiVersion: sealer.io/v2
kind: Cluster
metadata:
  name: my-cluster
spec:
  hosts:
  - ips:
    - 172.16.26.168
    roles:
    - master
    ssh: {}
  image: myapp:v1
  appNames: ["app3"]
  ssh:
    passwd: xxxx
    pk: /root/.ssh/id_rsa
    port: "22"
    user: root
status: {}

Does this pull request fix one issue?

Fixes #2166

Describe how you did it

Describe how to verify it

Special notes for reviews

@codecov-commenter
Copy link

codecov-commenter commented Apr 4, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -6.05 ⚠️

Comparison is base (e04f69f) 19.33% compared to head (2e39ed6) 13.28%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2167      +/-   ##
==========================================
- Coverage   19.33%   13.28%   -6.05%     
==========================================
  Files          96      260     +164     
  Lines        8918    22228   +13310     
==========================================
+ Hits         1724     2953    +1229     
- Misses       6953    18879   +11926     
- Partials      241      396     +155     
Flag Coverage Δ
e2e-tests 9.22% <ø> (?)
unit-tests 19.34% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/application/v2app.go 30.05% <100.00%> (+0.36%) ⬆️

... and 164 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Collaborator

@Stevent-fei Stevent-fei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kakaZhou719 kakaZhou719 merged commit 006e1db into sealerio:main Apr 6, 2023
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

failed to parse application from Clusterfile
3 participants