Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix env bug #2177

Merged
merged 1 commit into from
Apr 11, 2023
Merged

fix env bug #2177

merged 1 commit into from
Apr 11, 2023

Conversation

wizardlyk
Copy link
Collaborator

@wizardlyk wizardlyk commented Apr 10, 2023

Describe what this PR does / why we need it

[root@iZbp133pwc8drrt7ra1mkhZ ~]# cat .sealer/Clusterfile 
apiVersion: sealer.io/v2
kind: Cluster
metadata:
  name: my-cluster
spec:
  containerRuntime: {}
  env:
  - RegistryDomain=sea.hub
  - RegistryPort=5000
  - RegistryURL=sea.hub:5000

when dealing with cluster.env , convert string slice to map map[string]string instead of map[string]interface{}.
also, reslove value overwritten problem.

Does this pull request fix one issue?

Fixes #2174

Describe how you did it

Describe how to verify it

Special notes for reviews

@codecov-commenter
Copy link

codecov-commenter commented Apr 10, 2023

Codecov Report

Patch coverage has no change and project coverage change: -10.84 ⚠️

Comparison is base (006e1db) 19.34% compared to head (a9fa850) 8.50%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #2177       +/-   ##
==========================================
- Coverage   19.34%   8.50%   -10.84%     
==========================================
  Files          96     164       +68     
  Lines        8919   13309     +4390     
==========================================
- Hits         1725    1132      -593     
- Misses       6953   12028     +5075     
+ Partials      241     149       -92     
Flag Coverage Δ
e2e-tests 8.50% <ø> (?)
unit-tests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

see 260 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Stevent-fei
Copy link
Collaborator

@wizardlyk add some description

Signed-off-by: wb-lyk925458 <wb-lyk925458@alibaba-inc.com>
@wizardlyk
Copy link
Collaborator Author

@wizardlyk add some description

done

Copy link
Member

@kakaZhou719 kakaZhou719 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kakaZhou719 kakaZhou719 merged commit c268bc2 into sealerio:main Apr 11, 2023
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[feature] make cluster env more easy to understand
4 participants