optimize scale-up and delete node #2185
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wizardlyk
changed the title
wizardlyk
force-pushed
the
fix/scale-up
branch
2 times, most recently
from
0e88334
to
9f42c20
Compare
Codecov ReportPatch coverage has no change and project coverage change:
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more Additional details and impacted files@@ Coverage Diff @@
## main #2185 +/- ##
==========================================
- Coverage 20.01% 13.48% -6.54%
==========================================
Files 98 263 +165
Lines 9182 22677 +13495
==========================================
+ Hits 1838 3057 +1219
- Misses 7090 19209 +12119
- Partials 254 411 +157
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
|
learned, very strong🐂🍺 |
Stevent-fei
approved these changes
Apr 13, 2023
cubxxw
approved these changes
Apr 14, 2023
|
以下几个问题:configureLvs |
|
以下几个问题:
|
VinceCui
requested changes
Apr 17, 2023
pkg/registry/local.go
Outdated
| logrus.Infof("failed to ssh host %s, your ssh connet has timed out. skip flush ipvs policy on %s", n, n) | ||
| logrus.Debugf("ssh err: %v", err) | ||
| return nil | ||
| } else if strings.Contains(err.Error(), "unable to authenticate") { |
There was a problem hiding this comment.
这里有问题，首先，这里不应该走到ssh旧节点的逻辑，其次，ssh新节点时，如果密码失败，此处应该报错。
|
|
wizardlyk
force-pushed
the
fix/scale-up
branch
2 times, most recently
from
c9f5056
to
8f7b369
Compare
Signed-off-by: wb-lyk925458 <wb-lyk925458@alibaba-inc.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe what this PR does / why we need it
scale-up/delete new node will not depend on all existing nodes reachable.
Does this pull request fix one issue?
Fixes #1998
Describe how you did it
Describe how to verify it
Special notes for reviews