Feat/make all masters equal and make join cmd more robust #2218
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: huaiyou <huaiyou.cyz@alibaba-inc.com>
Signed-off-by: huaiyou <huaiyou.cyz@alibaba-inc.com>
Signed-off-by: huaiyou <huaiyou.cyz@alibaba-inc.com>
VinceCui
force-pushed
the
feat/all-masters-equal
branch
from
175d68d
to
116f29a
Compare
Codecov ReportPatch coverage has no change and project coverage change:
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. Additional details and impacted files@@ Coverage Diff @@
## main #2218 +/- ##
==========================================
- Coverage 19.93% 13.47% -6.46%
==========================================
Files 98 263 +165
Lines 9220 22757 +13537
==========================================
+ Hits 1838 3067 +1229
- Misses 7128 19280 +12152
- Partials 254 410 +156
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
starnop
reviewed
May 15, 2023
| if err := k.infra.Copy(host, k.getPKIPath(), clustercert.KubeDefaultCertPath); err != nil { | ||
| return fmt.Errorf("failed to copy cluster cert: %v", err) | ||
| } | ||
| if err := k.infra.Copy(host, k.getPKIPath(), k.getPKIPath()); err != nil { |
There was a problem hiding this comment.
transform pki to all master's rootfs, so when master0 down, other master can scale up cluster.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe what this PR does / why we need it
This PR support the follow abilities:
Does this pull request fix one issue?
Describe how you did it
Describe how to verify it
Special notes for reviews