opt: sealer common values #2246
Conversation
Codecov ReportPatch coverage:
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. Additional details and impacted files@@ Coverage Diff @@
## main #2246 +/- ##
==========================================
- Coverage 19.96% 13.68% -6.28%
==========================================
Files 98 260 +162
Lines 9323 22594 +13271
==========================================
+ Hits 1861 3092 +1231
- Misses 7207 19088 +11881
- Partials 255 414 +159
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
pkg/logger/file_hook.go
Outdated
| @@ -29,7 +29,7 @@ import ( | |||
|
|
|||
| func NewFileHook(filePath string) (logrus.Hook, error) { | |||
| if filePath == "" { | |||
| filePath = common.DefaultLogDir | |||
| filePath = common.GetSealerWorkDir() | |||
There was a problem hiding this comment.
the log dir will be changed here?
pkg/logger/logger.go
Outdated
| @@ -20,7 +20,7 @@ import ( | |||
| ) | |||
|
|
|||
| type LogOptions struct { | |||
| // sealer log file path, default log directory is `/var/lib/sealer/log` | |||
| // sealer log file path, default log directory is `/$HOME/.sealer/sealer.log` | |||
There was a problem hiding this comment.
I think the file path should not be arbitrarily modified
Signed-off-by: kakzhou719 <kakazhou719@163.com>
kakaZhou719
force-pushed
the
optimize-sealer-common
branch
from
093f75b
to
b7994f4
Compare
Describe what this PR does / why we need it
no logic changed, just remove some unused code to make code more clearly
Does this pull request fix one issue?
Describe how you did it
Describe how to verify it
Special notes for reviews