Skip to content

Commit

Permalink
fix passenger split error
Browse files Browse the repository at this point in the history
  • Loading branch information
ZHENG-JING-JZ committed Dec 13, 2018
1 parent 8e6de83 commit 0c7e880
Show file tree
Hide file tree
Showing 2 changed files with 21 additions and 1 deletion.
2 changes: 1 addition & 1 deletion lib/quick_travel/reservation.rb
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ def passengers_count(booking)
passenger_type_count = {}
if passenger_splits.present?
passenger_splits.each do |p|
passenger = booking.find_passenger_by_id(p['consumer_id'])
passenger = booking.find_passenger_by_id(p.consumer_id)

if passenger.present?
passenger_type_count[passenger.passenger_type_id] ||= 0
Expand Down
20 changes: 20 additions & 0 deletions spec/reservation_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -48,3 +48,23 @@
expect(@reservation.gross_including_packaged_item).to be_an_instance_of Money
end
end

describe QuickTravel::Reservation do
before(:each) do
VCR.use_cassette('reservation_with_extra_picks') do
@booking = QuickTravel::Booking.find(1)
@reservation = @booking.reservations.first
end
end

it 'should convert hash to objects' do
expect(@reservation.passenger_splits.first).to be_an_instance_of QuickTravel::PassengerSplit
end

let(:test_type) { double(name: 'test') }

it 'should not raise error in passenger count' do
allow(QuickTravel::PassengerType).to receive(:find).and_return(test_type)
expect{ @reservation.passengers_count(@booking) }.not_to raise_error
end
end

0 comments on commit 0c7e880

Please sign in to comment.