Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Price quotes #32

Merged
merged 6 commits into from
Apr 8, 2016
Merged

Price quotes #32

merged 6 commits into from
Apr 8, 2016

Conversation

alxberardi
Copy link
Contributor

No description provided.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.07%) to 74.716% when pulling c957624 on price_quotes into c8eaf0c on master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.2%) to 74.834% when pulling c957624 on price_quotes into c8eaf0c on master.

@mnoack
Copy link
Contributor

mnoack commented Apr 8, 2016

👍 (My understanding is booking-app needs to update to avoid breaking, which is fine by me)

@mnoack
Copy link
Contributor

mnoack commented Apr 8, 2016

By that I mean if we just update the client it will break, so we should update the caller in booking-app :)

@alxberardi
Copy link
Contributor Author

Yes @mnoack , it is a wanted behaviour and I'm preparing a PR in booking app.

@alvinypyim
Copy link
Contributor

👍

@alvinypyim alvinypyim merged commit 5876bcd into master Apr 8, 2016
@alxberardi alxberardi deleted the price_quotes branch April 8, 2016 05:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@alxberardi @coveralls @mnoack @alvinypyim