Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix error in priced? check when product does not have pricing_details #82

Merged
merged 15 commits into from
Mar 22, 2019

Conversation

tlclink
Copy link
Contributor

@tlclink tlclink commented Mar 7, 2019

No description provided.

@coveralls
Copy link

coveralls commented Mar 7, 2019

Coverage Status

Coverage remained the same at 83.419% when pulling 88a8aa5 on DC-1692-errors-in-priced-method into c4750c9 on master.

@tlclink
Copy link
Contributor Author

tlclink commented Mar 7, 2019

The CI errors are all bundler errors so I'm guessing its a CI configuration problem
@HellRok who manages those configurations?

@HellRok
Copy link
Contributor

HellRok commented Mar 7, 2019

@tlclink The configurations are commited into the repository (look into .travis.yml)

Very strange it failed on 2.3 but passed on all other versions (including 2.2), might be worth changing the script line to be script: gem install bundler && bundle && bundle exec rake spec

@tlclink
Copy link
Contributor Author

tlclink commented Mar 7, 2019

@HellRok sadly that didn't make any difference :(

@jmortlock
Copy link
Contributor

There are a few ways to fix this.
Update our Rails4 GemSpec to match the bundler requirements from upstream rails

s.add_dependency 'bundler', '>= 1.3.0', '< 2.0'

Or can always enforce bundler < 2 by pre-installing

before_install:
  gem install bundler -v "~>1.0"

@tlclink
Copy link
Contributor Author

tlclink commented Mar 12, 2019

@jmortlock

There are a few ways to fix this.
Update our Rails4 GemSpec to match the bundler requirements from upstream rails

s.add_dependency 'bundler', '>= 1.3.0', '< 2.0'

Or can always enforce bundler < 2 by pre-installing

before_install:
  gem install bundler -v "~>1.0"

Did you mean to apply the add_dependency change in the quicktravel_client.gemspec or a different file?

@jmortlock
Copy link
Contributor

gemfiles/rails4.gemfile

@tlclink
Copy link
Contributor Author

tlclink commented Mar 12, 2019

@jmortlock unfortunatley neither of your suggestions appear to work :(
unless I didn't apply the suggestions correctly

@jmortlock
Copy link
Contributor

Nice one, 6th times a charm

@jmortlock jmortlock merged commit fe0a7d8 into master Mar 22, 2019
@jmortlock jmortlock deleted the DC-1692-errors-in-priced-method branch March 22, 2019 05:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants