Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TT-6539: Remove cache_all_attributes and other changes #34

Merged
merged 2 commits into from
Dec 11, 2019
Merged

TT-6539: Remove cache_all_attributes and other changes #34

merged 2 commits into from
Dec 11, 2019

Conversation

tlevi
Copy link
Contributor

@tlevi tlevi commented Dec 10, 2019

Removing this as it is getting shifted into QT to clean remaining use case and is otherwise unused.

Removed some other methods which seem unused.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.07%) to 87.097% when pulling 3b9fa3c on TT-6539-remove-cache-all-attributes into 5f6031b on master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage increased (+0.07%) to 87.097% when pulling 3b9fa3c on TT-6539-remove-cache-all-attributes into 5f6031b on master.

@coveralls
Copy link

coveralls commented Dec 10, 2019 •
edited

Coverage Status

Coverage decreased (-0.008%) to 87.017% when pulling a65ac6c on TT-6539-remove-cache-all-attributes into 5f6031b on master.

@tlevi tlevi force-pushed the TT-6539-remove-cache-all-attributes branch from 831bf17 to a65ac6c Compare December 11, 2019 00:36
@HellRok HellRok merged commit 1d66f18 into master Dec 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sam-wan sam-wan sam-wan approved these changes

@HellRok HellRok HellRok approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@tlevi @coveralls @sam-wan @HellRok