Merge a353864 into 51e8f92

.rubocop.yml

@@ -0,0 +1,21 @@
+inherit_gem:
+  rubocop-rails:
+    - config/rails.yml
+
+AllCops:
+  TargetRubyVersion: 2.4
+
+Style/FrozenStringLiteralComment:
+  Enabled: false
+
+Style/StringLiterals:
+  Enabled: false
+
+Layout/IndentationWidth:
+  IgnoredPatterns: ['^\s*private$']
+
+Style/BracesAroundHashParameters:
+  Enabled: false
+
+Metrics/LineLength:
+  Max: 100

CHANGELOG.md

@@ -5,6 +5,10 @@ This changelog adheres to [Keep a CHANGELOG](http://keepachangelog.com/).
 
 ## Unreleased
 
+### Added
+
+- [TT-4020] Implemented Rubocop
+
 ## 0.0.1
 
 ### Added

Rakefile

@@ -1,7 +1,7 @@
 require "bundler/gem_tasks"
 
 desc 'Default: run specs.'
-task :default => :spec
+task default: :spec
 
 require 'rspec/core/rake_task'
 

gemfiles/rails3.gemfile

@@ -1,5 +1,5 @@
 source 'https://rubygems.org'
-gemspec :path => '../'
+gemspec path: '../'
 
 group :development, :test do
   gem 'rake'

gemfiles/rails4.gemfile

@@ -1,5 +1,5 @@
 source 'https://rubygems.org'
-gemspec :path => '../'
+gemspec path: '../'
 
 group :development, :test do
   gem 'rake'

lib/ruby_core_extensions/array.rb

@@ -1,5 +1,4 @@
 class Array
-
   def to_param
     self.collect { |element| element.respond_to?(:to_param) ? element.to_param : element }
   end
@@ -31,7 +30,7 @@ def hash_by_id(method = nil, &block)
   end
 
   def intersects?(other)
-    self.any?{|i| other.include?(i)}
+    self.any? { |i| other.include?(i) }
   end
 
   # Same effect as Array.wrap(object).first

lib/ruby_core_extensions/class.rb

@@ -1,8 +1,5 @@
 class Class
-
   def downcase_symbol
     self.to_s.downcase.to_sym
   end
-
 end
-

lib/ruby_core_extensions/compact/array.rb

@@ -1,6 +1,6 @@
 class Array
   def compact_blank!
-    delete_if{|v| v.blank?}
+    delete_if { |v| v.blank? }
   end
 
   def recursive_compact_blank!
@@ -17,4 +17,3 @@ def recursive_compact_blank!
     end
   end
 end
-

lib/ruby_core_extensions/compact/hash.rb

@@ -6,19 +6,19 @@ def compact
 
   # Remove nil values - !desctructively!
   def compact!
-    delete_if{|k,v| v.nil?}
+    delete_if { |k, v| v.nil? }
   end
 
   def compact_blank
     self.dup.compact_blank!
   end
 
   def compact_blank!
-    delete_if{|k,v| v.blank?}
+    delete_if { |k, v| v.blank? }
   end
 
   def recursive_compact_blank!
-    delete_if do |k,v|
+    delete_if do |k, v|
       if v.is_a?(Hash)
         v.recursive_compact_blank!
         v.recursive_blank?
@@ -31,4 +31,3 @@ def recursive_compact_blank!
     end
   end
 end
-

lib/ruby_core_extensions/enumerable.rb

@@ -1,5 +1,4 @@
 module Enumerable
-
   def map_methods(*methods)
     map do |object|
       methods.inject({}) do |h, method|
@@ -34,6 +33,4 @@ def with_object(obj, &block)
       obj
     end
   end
-
 end
-

lib/ruby_core_extensions/file.rb

@@ -9,4 +9,3 @@ def self.safe_name(name)
       gsub(/\-+/, '-') # limit - character to once
   end
 end
-

lib/ruby_core_extensions/hash.rb

@@ -1,7 +1,6 @@
 class Hash
-
   unless self.method_defined?(:extract!)
-    #Imported from Rails 3
+    # Imported from Rails 3
     def extract!(*keys)
       result = {}
       keys.each { |key| result[key] = delete(key) }
@@ -12,23 +11,22 @@ def extract!(*keys)
 
   def map_key_value(key_method, value_method = nil)
     value_method ||= key_method
-    each.with_object({}) do |(k,v), new_hash|
+    each.with_object({}) do |(k, v), new_hash|
       new_hash[k.send(key_method)] = v.send(value_method)
     end
   end
 
 
   def map_key(method)
-    each.with_object({}) do |(k,v), new_hash|
+    each.with_object({}) do |(k, v), new_hash|
       new_hash[k.send(method)] = v
     end
   end
 
 
   def map_value(method)
-    each.with_object({}) do |(k,v), new_hash|
+    each.with_object({}) do |(k, v), new_hash|
       new_hash[k] = v.send(method)
     end
   end
-
 end

lib/ruby_core_extensions/kernel.rb

@@ -1,11 +1,9 @@
 module Kernel
-
   def require_dirs(dirs)
     Array.wrap(dirs).each do |load_path|
       Dir.glob("#{load_path}/**/*.rb").each do |file|
         require file
       end
     end
   end
-
 end

lib/ruby_core_extensions/numeric.rb

@@ -1,7 +1,5 @@
 class Numeric
-
   def to_bool
     !zero?
   end
-
 end

lib/ruby_core_extensions/object.rb

@@ -3,16 +3,16 @@ class Object
   def sounds_like?(other)
     self.phonetic_code == other.phonetic_code
   end
-  
+
   # Convert this object into a string, then convert that to phonetic code
   def phonetic_code
     self.to_s.phonetic_code
   end
-  
+
   def to_long_s
     to_s
   end
-  
+
   def virtual_belongs_to(*associations)
     options = associations.extract_options!
 
@@ -62,11 +62,9 @@ def #{normal_name}?(*args)
       end
     EVAL
   end
-  
-  
+
+
   def to_bool
     self.to_s.to_bool
   end
-
 end
-

lib/ruby_core_extensions/recursive/array.rb

@@ -1,45 +1,43 @@
- class Array 
-
-  def convert
-    self
-  end
+ class Array
+   def convert
+     self
+   end
 
-  def convert_keys_recursively(&converter)
-    map { |v| v.convert_keys_recursively(&converter) }
-  end
-
-  def convert_values_recursively(&converter)
-    map { |v| v.convert_values_recursively(&converter) }
-  end
-
-  def symbolize_keys_recursively
-    map(&:symbolize_keys_recursively)
-  end
-
-  def stringify_values_recursively
-    map(&:stringify_values_recursively)
-  end
-
-  def make_indifferent_access_recursively
-    map(&:make_indifferent_access_recursively)
-  end
-
-  def recursive_blank?
-    each do |v|
-      if v.respond_to?(:recursive_blank?)
-        return false unless v.recursive_blank?
-      else
-        return false unless v.blank?
-      end
-    end
-    true
-  end
-
-  def recursively(&block)
-    each do |element|
-      block.call(element)
-      element.recursively(&block) if element.respond_to?(:recursively)
-    end
-  end
-
-end
+   def convert_keys_recursively(&converter)
+     map { |v| v.convert_keys_recursively(&converter) }
+   end
+
+   def convert_values_recursively(&converter)
+     map { |v| v.convert_values_recursively(&converter) }
+   end
+
+   def symbolize_keys_recursively
+     map(&:symbolize_keys_recursively)
+   end
+
+   def stringify_values_recursively
+     map(&:stringify_values_recursively)
+   end
+
+   def make_indifferent_access_recursively
+     map(&:make_indifferent_access_recursively)
+   end
+
+   def recursive_blank?
+     each do |v|
+       if v.respond_to?(:recursive_blank?)
+         return false unless v.recursive_blank?
+       else
+         return false unless v.blank?
+       end
+     end
+     true
+   end
+
+   def recursively(&block)
+     each do |element|
+       block.call(element)
+       element.recursively(&block) if element.respond_to?(:recursively)
+     end
+   end
+ end

lib/ruby_core_extensions/recursive/date.rb

@@ -1,8 +1,5 @@
 class Date
-
   def stringify_values_recursively
     self.to_s
   end
-
 end
-

lib/ruby_core_extensions/recursive/date_time.rb

@@ -1,8 +1,5 @@
 class DateTime
-
   def stringify_values_recursively
     self.to_s
   end
-
 end
-

lib/ruby_core_extensions/recursive/fixnum.rb

@@ -1,7 +1,5 @@
 class Fixnum
-
   def stringify_values_recursively
     to_s
   end
-
 end