Initial release #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alxberardi
force-pushed
the
extraction_from_quicktravel
branch
from
7ad04d7
to
c7a8be7
Compare
mnoack
reviewed
Dec 8, 2016
|
|
||
| MINIMUM_COVERAGE = 100 | ||
|
|
||
| unless ENV['COVERAGE'] == 'off' |
There was a problem hiding this comment.
NOOOOOOOOOOOOOOO. sealink/timely@4109534
There was a problem hiding this comment.
Addressed @mnoack thanks!
Merged
|
Changes Unknown when pulling 8bdac29 on extraction_from_quicktravel into ** on master**. |
|
Changes Unknown when pulling 36291d4 on extraction_from_quicktravel into ** on master**. |
blaknite
force-pushed
the
extraction_from_quicktravel
branch
from
36291d4
to
8bdac29
Compare
|
I have some suggestions for review set up as a pr here: #3 |
This allows an EnvParser to mask iteslf which reduces object instantiations and simplifies the abstraction. As a result ParameterMasker has been removed and EnvParser now calls SensitiveDataFilter::Mask.mask_hash directly. Minor improvements to consistency of using parentheses.
PrameterScanner.new is immediately followed by a call to sensitive_data? meaning there is no reason to lazy-load the scans. They’re now just done on initialize.
Abstraction can be reduced resulting in a clear definition of the objects concern during initialization.
|
Changes Unknown when pulling b4d3f7c on extraction_from_quicktravel into ** on master**. |
blaknite
approved these changes
Dec 9, 2016
|
Changes Unknown when pulling d0249eb on extraction_from_quicktravel into ** on master**. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extracted from QuickTravel