TF-36 Add to_seconds method in Period class #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Damon1024
requested review from
Damon1024,
Griffinstein,
johnjunjiezhao,
jmortlock,
sam-wan and
Steffylicious
sam-wan
approved these changes
Feb 15, 2023
|
Coverage is failing the build, you need to add tests which should be relatively straight forward |
|
There 10 conversions should be 10 test cases |
|
Test cases added |
Damon1024
approved these changes
Feb 15, 2023
jmortlock
approved these changes
Feb 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Add to_seconds method in Period class for using in QT