CLOSED - issue SEAMSOCIAL-14: Avoid using an Enum to qualify services

https://issues.jboss.org/browse/SEAMSOCIAL-14
seam · Jun 21, 2011 · fc6cc34 · fc6cc34
1 parent 194cdf1
commit fc6cc34
Show file tree

Hide file tree

Showing 3 changed files with 17 additions and 5 deletions.
diff --git a/api/src/main/java/org/jboss/seam/social/oauth/MultiServicesManager.java b/api/src/main/java/org/jboss/seam/social/oauth/MultiServicesManager.java
@@ -33,7 +33,7 @@ public interface MultiServicesManager {
     /**
      * @return Set of available service to connect to
      */
-    public Set<String> getListOfServices();
+    public List<String> getListOfServices();
 
     /**
      * Add a service to the Set of services to manage

diff --git a/impl/src/main/java/org/jboss/seam/social/oauth/MultiServicesManagerImpl.java b/impl/src/main/java/org/jboss/seam/social/oauth/MultiServicesManagerImpl.java
@@ -18,9 +18,13 @@
 
 
 import java.io.Serializable;
+import java.util.ArrayList;
+import java.util.Collections;
 import java.util.HashSet;
+import java.util.List;
 import java.util.Set;
 
+import javax.annotation.PostConstruct;
 import javax.enterprise.inject.Any;
 import javax.enterprise.inject.Instance;
 import javax.inject.Inject;
@@ -38,19 +42,28 @@ public class MultiServicesManagerImpl implements MultiServicesManager,Serializab
     private Instance<OAuthService> serviceInstances;
 
     @Inject
-    private Set<String> listOfServices;
+    private SeamSocialExtension socialConfig;
+
+    private List<String> listOfServices;
 
     private Set<OAuthService> services;
 
     private OAuthService currentService;
 
+
+    @PostConstruct
+    private void init()
+    {
+        listOfServices=new ArrayList<String>(socialConfig.getSocialRelated());
+    }
+
     /*
      * (non-Javadoc)
      * 
      * @see org.jboss.seam.social.manager.MultiServicesManager#getListOfServices()
      */
     @Override
-    public Set<String> getListOfServices() {
+    public List<String> getListOfServices() {
         return listOfServices;
     }
 

diff --git a/impl/src/main/java/org/jboss/seam/social/oauth/SeamSocialExtension.java b/impl/src/main/java/org/jboss/seam/social/oauth/SeamSocialExtension.java
@@ -21,7 +21,6 @@
 
 import javax.enterprise.context.ApplicationScoped;
 import javax.enterprise.event.Observes;
-import javax.enterprise.inject.Produces;
 import javax.enterprise.inject.spi.Annotated;
 import javax.enterprise.inject.spi.BeanManager;
 import javax.enterprise.inject.spi.Extension;
@@ -53,7 +52,7 @@ public void processBeans(@Observes ProcessBean<OAuthService> pbean, BeanManager
         }
     }
 
-    @Produces
+
     public Set<String> getSocialRelated() {
         return servicesNames;
     }