Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

/workspaces/create: rename workspace_name to name param #190

Merged
merged 1 commit into from
Mar 29, 2024

Conversation

andrii-balitskyi
Copy link
Contributor

@andrii-balitskyi andrii-balitskyi commented Mar 28, 2024

It seems a bit unusual that the internal and public /workspaces/create endpoints differ regarding this name parameter, but that’s currently the case with seam-connect. For now, I’m aligning with this to ensure our Python SDK tests pass. We can look into harmonizing these endpoints on the seam-connect side as a future improvement.

@andrii-balitskyi andrii-balitskyi changed the title /workspaces/create: rename workspace name param /workspaces/create: rename workspace name param Mar 28, 2024
@andrii-balitskyi andrii-balitskyi changed the title /workspaces/create: rename workspace name param /workspaces/create: rename workspace_name to name param Mar 28, 2024
@seambot
Copy link
Contributor

seambot commented Mar 28, 2024

Bundle dist size: 21M

Copy link
Collaborator

@razor-x razor-x left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Curious what depends on the fake implementing this internal endpoint

@andrii-balitskyi
Copy link
Contributor Author

andrii-balitskyi commented Mar 29, 2024

Curious what depends on the fake implementing this internal endpoint

@razor-x The change is for our public /workspaces/create endpoint. However, we also have a very similar endpoint, /internal/workspaces/create, from which I imported the jsonBody. The two endpoints are nearly identical, with the main difference being the parameter name for the workspace name: it's workspace_name in the internal endpoint and simply name in the public one. Our Python SDK has a test for the public endpoint.

@andrii-balitskyi andrii-balitskyi merged commit 587dab5 into main Mar 29, 2024
31 checks passed
@andrii-balitskyi andrii-balitskyi deleted the fix-workspace-name branch March 29, 2024 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants