Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Collective update from fake template #32

Merged
merged 75 commits into from
Jul 20, 2023
Merged

Collective update from fake template #32

merged 75 commits into from
Jul 20, 2023

Conversation

razor-x
Copy link
Collaborator

@razor-x razor-x commented Jul 20, 2023

Nothing here is new. These updates are ported from our core fake template. Fixes a few known issues and update the structure to match the current standard.

Still worth some more eyes, as while I did my best diff-fu to bring things up to date, it's possible there is a mistake (already found and fixed some when I reviewed it here), plus it's a good time to ask questions about any changes that don't seem familiar.

@seambot
Copy link
Contributor

seambot commented Jul 20, 2023

Bundle dist size: 25M

Copy link
Contributor

@seveibar seveibar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is breaking in a couple places i think but lgtm

@razor-x
Copy link
Collaborator Author

razor-x commented Jul 20, 2023

@seveibar Ah yea, as in breaking changes? It might be but we are pre v1. Actually I've been meaning to make this update for quite a while now as my plan was to do this update before v1.

@seveibar
Copy link
Contributor

@razor-x yep sounds good!

@razor-x razor-x merged commit 39422c7 into main Jul 20, 2023
21 checks passed
@razor-x razor-x deleted the updates-from-template-3 branch July 20, 2023 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants