-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Collective update from fake template #32
Conversation
8d76c72
to
0e378ee
Compare
0e378ee
to
f1ee849
Compare
09a6d3f
to
82af96d
Compare
Bundle |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is breaking in a couple places i think but lgtm
@seveibar Ah yea, as in breaking changes? It might be but we are pre v1. Actually I've been meaning to make this update for quite a while now as my plan was to do this update before v1. |
@razor-x yep sounds good! |
Nothing here is new. These updates are ported from our core fake template. Fixes a few known issues and update the structure to match the current standard.
Still worth some more eyes, as while I did my best diff-fu to bring things up to date, it's possible there is a mistake (already found and fixed some when I reviewed it here), plus it's a good time to ask questions about any changes that don't seem familiar.