Generate get method over post when both exist #115
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
razor-x
force-pushed
the
missing-get
branch
from
bbc04b0
to
457fe98
Compare
razor-x
force-pushed
the
missing-get
branch
from
457fe98
to
7411608
Compare
razor-x
requested review from
seveibar,
codetheweb and
itelo
as code owners
codetheweb
approved these changes
Sep 29, 2023
seveibar
reviewed
Sep 29, 2023
| !isGet && | ||
| ["POST", "PUT", "PATCH"].some((method) => | ||
| routeSpec.methods.includes(method) | ||
| ) |
There was a problem hiding this comment.
I feel like we should either 1) flag this or 2) have seam connect perform the filtering
There was a problem hiding this comment.
i'm leaning towards (2), I don't think nextlove should have this kind of preference
There was a problem hiding this comment.
Right now it does have a preference, so this update just switches the preference. We can flag it. We can't do 2 unless we update this function to generate all methods. Good first issue? I'd need help on this one.
There was a problem hiding this comment.
I would like to merge this and update seam connect to use it. I can add a flag if we think there is impact other than seam connect, but I consider this a bug at the moment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.