Add disableConnectedAccountInformation #623
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
razor-x
commented
Apr 27, 2024
razor-x
commented
- feat: Add disableConnectedAccountInformation
- Move DeviceInfo to component
- feat: Add device info to lock DeviceDetails
dawnho
reviewed
Apr 29, 2024
| {device.properties.manufacturer === 'ecobee' && <BeeIcon />} | ||
| </div> | ||
| </DetailRow> | ||
| {!disableConnectedAccountInformation && ( |
There was a problem hiding this comment.
This is meant to be for the whole section, not just the connect account row.
There was a problem hiding this comment.
@dawnho This will hide the connected account info. The device id is not related to the connect account but may be hidden with disableResourceIds.
I feel the manufacturer information is fine to leave in here, but we could add a prop to hide that as well: disableManufacturerInformation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.