We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
format auto-detection is bad because it doesn't start at the end when looking for extnames:
foo.csv -> detected as csv foo.xls -> detected as xls fooxls.csv -> detected as xls (WRONG)
it should probably choose the format whose extname has the highest rindex
rindex
it should probably keep looking in the basename, otherwise we won't be smart about filenames like "foo_xlsx" which to a human is obviously an xlsx.
assigning to @activefx in case he's got time
The text was updated successfully, but these errors were encountered:
2552468
simpler and better to use \z than what i suggested (rindex) - thank you!
\z
please add to CHANGELOG
Sorry, something went wrong.
No problem. Does it go under 2.1.1 as a bug fix? Should I update the corresponding date to today?
i use a manual version bump / tag / release process - check out 63db4bc - all done for now
correctly detect table format in filename - Fixes #10
ed4e389
Conflicts: lib/remote_table.rb
activefx
No branches or pull requests
format auto-detection is bad because it doesn't start at the end when looking for extnames:
foo.csv -> detected as csv
foo.xls -> detected as xls
fooxls.csv -> detected as xls (WRONG)
it should probably choose the format whose extname has the highest
rindex
it should probably keep looking in the basename, otherwise we won't be smart about filenames like "foo_xlsx" which to a human is obviously an xlsx.
assigning to @activefx in case he's got time
The text was updated successfully, but these errors were encountered: