Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

format detection confused by extname appearing in basename #10

Closed
seamusabshere opened this issue Sep 9, 2013 · 3 comments
Closed

format detection confused by extname appearing in basename #10

seamusabshere opened this issue Sep 9, 2013 · 3 comments
Assignees

Comments

@seamusabshere
Copy link
Owner

format auto-detection is bad because it doesn't start at the end when looking for extnames:

foo.csv -> detected as csv
foo.xls -> detected as xls
fooxls.csv -> detected as xls (WRONG)

it should probably choose the format whose extname has the highest rindex

it should probably keep looking in the basename, otherwise we won't be smart about filenames like "foo_xlsx" which to a human is obviously an xlsx.

assigning to @activefx in case he's got time

@ghost ghost assigned activefx Sep 9, 2013
@seamusabshere
Copy link
Owner Author

simpler and better to use \z than what i suggested (rindex) - thank you!

please add to CHANGELOG

@activefx
Copy link
Collaborator

activefx commented Oct 8, 2013

No problem. Does it go under 2.1.1 as a bug fix? Should I update the corresponding date to today?

@seamusabshere
Copy link
Owner Author

i use a manual version bump / tag / release process - check out 63db4bc - all done for now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants