Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider not using .clj for extension of template source files #39

Closed
seancorfield opened this issue Nov 24, 2022 · 3 comments
Closed
Assignees
Labels
documentation Improvements or additions to documentation enhancement New feature or request

Comments

@seancorfield
Copy link
Owner

These files are not valid Clojure (and probably are not valid EDN either).

This should help avoid problems with tooling downstream, for anything that might assume it can load .clj files as Clojure code.

Probably ought to update the docs too, so folks building their own templates do not trip over this.

@seancorfield seancorfield added documentation Improvements or additions to documentation enhancement New feature or request labels Nov 24, 2022
@seancorfield seancorfield self-assigned this Nov 24, 2022
@imrekoszo
Copy link

For the sake of documentation and for anyone trying to look into the whys:

@seancorfield
Copy link
Owner Author

A note about this: deps-new can either copy entire directories (recursively) or individual files. When copying individual files, it's easy to take any source file and copy it to a .clj file (or whatever) but directories are copied "as-is" (modulo internal {{var}} substitution).

The existing templates contain a root folder that is copied to the new project folder and includes build.clj, so that file is going to need to be pulled out separately in order to change its file extension.

@seancorfield
Copy link
Owner Author

Fixed in v0.5.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants