Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Security: Make it clearer that you really need :quoted true to avoid injection via table/column names #422

Closed
seancorfield opened this issue Aug 19, 2022 · 3 comments
Assignees
Labels
documentation I need to write something up!

Comments

@seancorfield
Copy link
Owner

If you have a dialect set as the default, :quoted false is the default and if you pass through user input as keywords (or symbols) for table/column/function names etc, those could be used to produce malicious SQL.

Also, make it clear that using arbitrary strings as aliases would also allow that.

@seancorfield seancorfield added the documentation I need to write something up! label Aug 19, 2022
@seancorfield seancorfield self-assigned this Aug 19, 2022
@seancorfield
Copy link
Owner Author

Suggestion: auto-quote suspicious looking entities unless :quoted false (so make quoting a tristate value).

@seancorfield
Copy link
Owner Author

Updated PR #424 with a first pass on documentation as well as the auto-quoting of "unusual" entities.

seancorfield added a commit that referenced this issue Sep 4, 2022
@seancorfield
Copy link
Owner Author

Closing as documented sufficiently for release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation I need to write something up!
Projects
None yet
Development

No branches or pull requests

1 participant