Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A better name for reducible! perhaps? #16

Closed
seancorfield opened this issue Apr 24, 2019 · 9 comments

Comments

Projects
None yet
5 participants
@seancorfield
Copy link
Owner

commented Apr 24, 2019

Per @ghadishayban on Slack:

reducible! is also a terrible name, while we're at it (edited)
reducible <Action> <----what's the action? I have a hard time with this one

This issue is a placeholder for discussion about possible better names.

@lensgolda

This comment has been minimized.

Copy link

commented Apr 26, 2019

Maybe prune! or shrink!...?

@seancorfield

This comment has been minimized.

Copy link
Owner Author

commented Apr 26, 2019

@lensgolda Those are even less descriptive than reducible! for what it does.

@lensgolda

This comment has been minimized.

Copy link

commented Apr 26, 2019

agree... so why it should has better name? I don't think reducible not enough descriptive, and such terrible name as mentioned in slack above...Sorry, maybe i didn't understand reasons for that.

@seancorfield

This comment has been minimized.

Copy link
Owner Author

commented Apr 26, 2019

Well, I happen to agree with you. It produces a "reducible" thing. That's why I named it reducible!. But if some folks think it's a terrible name, I'm happy to take feedback on better names while the library is in the alpha state. The equivalent in clojure.java.jdbc is reducible-query (because it only works for queries) but it's long and ugly so I wanted something shorter/simpler.

@Lokeh

This comment has been minimized.

Copy link

commented May 10, 2019

I sometimes like as-x to note that I am returning a thing with some specific behavior / protocol / etc., so e.g. as-reducible. It feels like bikeshedding though.

@andharris

This comment has been minimized.

Copy link

commented May 13, 2019

executable!?

Reading the description in the REAMDE

  • reducible! -- yields an IReduceInit that, when reduced, executes the SQL statement and then reduces over the ResultSet with as little overhead as possible.

It seems like this is creating something that makes the SQL executable when it's reduced.

To me this makes sense in relation to execute! that realizes the SQL ResultSet immediately.

@ghadishayban

This comment has been minimized.

Copy link

commented May 22, 2019

(->>
  (jdbc/plan (ds) ["select * from fruit where appearance = ?" "red"])
  (into []))

May I suggest plan? It has the desired connotation that it's not immediately doing anything, and doesn't overload prepare (as in prepared statement)

@seancorfield

This comment has been minimized.

Copy link
Owner Author

commented May 22, 2019

Thanks, @ghadishayban -- I like that.

I plan to move to Beta 1 "soon" and will make this change at that point -- and then no more breaking changes or renaming, from that point on.

I have been thinking about the group/artifact ID and the namespace names too but at this point, I'm pretty sure I'm going to stick with seancorfield/next.jdbc for the coordinates and next.jdbc.* for the namespaces. Given that I want to avoid clojure or any variant of that, since this is almost certainly not going into Contrib at this point, and I don't want my name in the namespace names, I'm fine with the current schema...

seancorfield added a commit that referenced this issue May 22, 2019

@seancorfield

This comment has been minimized.

Copy link
Owner Author

commented May 22, 2019

Closing as Beta 1 is in preparation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.