Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ADD apparent wind for WindBarbsOnRoute #224

Merged
merged 1 commit into from
Sep 7, 2018

Conversation

theeko74
Copy link
Contributor

@theeko74 theeko74 commented Sep 5, 2018

Change from true wind direction and speed to apparent wind direction
and speed as it is the conditions that we have on the boat...
For example, it helps to see if we can do upwind or not.

@rgleason
Copy link
Contributor

rgleason commented Sep 5, 2018

Sounds reasonable to me. Does it conflict with anything else in the plugin?
The grib files show True wind. The boat feathers at optimal route would now show Apparent?

@theeko74
Copy link
Contributor Author

theeko74 commented Sep 5, 2018

Yes, before WindBbarbOnRoute was showing True wind (direction and speed). I think this is more interesting to display Apparent Wind (direction and speed). For example, before if you see wind coming from side (90°) then when you are sailing you see wind coming from 70° because of the boat speed. So people think prevision was not correct...

@theeko74
Copy link
Contributor Author

theeko74 commented Sep 5, 2018

This will not impact any thing in the plugin as it is only related to WindBarbOnRoute option.

@rgleason
Copy link
Contributor

rgleason commented Sep 6, 2018

I hope Sean will merge. Thank you. I'll add a note in manual when he does so.

@seandepagnier
Copy link
Owner

seandepagnier commented Sep 6, 2018 via email

@theeko74 theeko74 force-pushed the MOD-barbs branch 2 times, most recently from d20dc09 to 5ce435b Compare September 6, 2018 23:52
@theeko74
Copy link
Contributor Author

theeko74 commented Sep 6, 2018

You're right @seandepagnier can you tell me if this is fix now and showing apparent wind (and not true wind)? Thanks

@seandepagnier
Copy link
Owner

I don't have a problem to make this a display option, but by default, wind barbs rendered on the chart are understood to mean true wind, not apparent wind.

This is now an option, and the wind barbs have a different color if user
selects apparent wind to distinguish from true wind.
@theeko74
Copy link
Contributor Author

theeko74 commented Sep 7, 2018

OK, this is now an option + WindBarbsOnRoute have a blue color to distinguish from default true wind.
What do you think?

@theeko74
Copy link
Contributor Author

theeko74 commented Sep 7, 2018

By the way @seandepagnier I am sorry but the other PR #226 includes the old version of apparent windBarbsOnRoute... If you merge this PR this should solve it.

@seandepagnier seandepagnier merged commit 950f470 into seandepagnier:master Sep 7, 2018
@theeko74 theeko74 deleted the MOD-barbs branch September 10, 2018 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants