Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix parameter simulation for ClassVars with mutable defaults #134

Merged
merged 2 commits into from
Oct 11, 2020

Conversation

seandstewart
Copy link
Owner

resolves #132

@seandstewart seandstewart added the bug Something isn't working label Oct 11, 2020
@codecov
Copy link

codecov bot commented Oct 11, 2020

Codecov Report

Merging #134 into main will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #134   +/-   ##
=======================================
  Coverage   96.93%   96.93%           
=======================================
  Files          36       36           
  Lines        3854     3856    +2     
=======================================
+ Hits         3736     3738    +2     
  Misses        118      118           
Flag Coverage Δ
#3.8 96.93% <100.00%> (+<0.01%) ⬆️
#unittests 96.93% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
typic/serde/resolver.py 95.33% <100.00%> (+0.03%) ⬆️
typic/ext/schema/schema.py 97.35% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0857bf8...f9910a0. Read the comment docs.

@seandstewart seandstewart merged commit 6058321 into main Oct 11, 2020
@seandstewart seandstewart deleted the bug/132/classvar-with-mutable-default branch January 5, 2021 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ClassVar with unhashable default value cause TypeError
1 participant