Fix various cmake issues #54
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
thefallentree
commented
Oct 25, 2019
thefallentree
commented
- Look for zlib and set HAVE_ZLIB
- Avoid building and installing doxygen if there is no doxgen.
and remove the redundant TELNET_TELOPT_COMPRESS2 check Signed-off-by: Xiang Xiao <xiaoxiang@xiaomi.com>
Signed-off-by: Xiang Xiao <xiaoxiang@xiaomi.com>
Signed-off-by: Xiang Xiao <xiaoxiang@xiaomi.com>
… return NULL Signed-off-by: Xiang Xiao <xiaoxiang@xiaomi.com>
to handle the remote end close correctly Signed-off-by: Xiang Xiao <xiaoxiang@xiaomi.com>
seanmiddleditch
requested changes
Feb 5, 2020
| @@ -437,7 +436,8 @@ static void _negotiate(telnet_t *telnet, unsigned char telopt) { | |||
| break; | |||
| case Q_WANTNO_OP: | |||
| _set_rfc1143(telnet, telopt, Q_US(q), Q_WANTYES); | |||
| NEGOTIATE_EVENT(telnet, TELNET_EV_DO, telopt); | |||
| _send_negotiate(telnet, TELNET_DO, telopt); | |||
There was a problem hiding this comment.
This don't seem to be related to the CMake issues; can you split these out to a separate PR? (Although I believe these are already addressed by another open PR.)
There was a problem hiding this comment.
#57
I don't know why my PR mix into your PR.
| @@ -1,11 +1,16 @@ | |||
| cmake_minimum_required(VERSION 3.5) | |||
| cmake_minimum_required(VERSION 3.10) | |||
There was a problem hiding this comment.
Is this required? I'm tentative to bump the minimum required here without a really good reason.
|
I should close this one for now to catch up until everyone else's has been merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.