Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Miri #60

Open
abonander opened this issue Aug 28, 2019 · 0 comments
Open

Support Miri #60

abonander opened this issue Aug 28, 2019 · 0 comments

Comments

@abonander
Copy link
Contributor

Miri is currently choking on the use of is_x86_feature_detected!() here: https://github.com/seanmonstar/httparse/blob/master/src/simd/mod.rs#L74

Miri is probably not going to be supporting SIMD anytime soon anyway so it'd be nice if we could use #[cfg(miri)] to turn off feature detection entirely and just use the naive algorithms.

This could potentially happen automatically but this crate may need attention in other places in order to work in Miri.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant