refactor: Bytes inner arithmetic #138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AaronO
added a commit
to AaronO/httparse
that referenced
this pull request
Apr 24, 2023
Builds off seanmonstar#134 (swar), seanmonstar#138 (Bytes cursor) Cleaner, faster and less macros ! ## Key changes - Broke down header-parsing into clean conceptual steps (whilst being faster !) - Added InnerResult allowing for idiomatic `?` early-exits, removing need for parsing-helper macros - Removed macros.rs, leaving only `byte_map!` (response header-parsing macros should become functions) ### TODO - convert request header-parser, supporting its quirks
AaronO
added a commit
to AaronO/httparse
that referenced
this pull request
Apr 24, 2023
Builds off seanmonstar#134 (swar), seanmonstar#138 (Bytes cursor) Cleaner, faster and less macros ! - Broke down header-parsing into clean conceptual steps (whilst being faster !) - Added InnerResult allowing for idiomatic `?` early-exits, removing need for parsing-helper macros - Removed macros.rs, leaving only `byte_map!` (response header-parsing macros should become functions) - convert response header-parser, supporting its quirks
AaronO
added a commit
to AaronO/httparse
that referenced
this pull request
Apr 24, 2023
Builds off seanmonstar#134 (swar), seanmonstar#138 (Bytes cursor) Cleaner, faster and less macros ! - Broke down header-parsing into clean conceptual steps (whilst being faster !) - Added InnerResult allowing for idiomatic `?` early-exits, removing need for parsing-helper macros - Removed macros.rs, leaving only `byte_map!` (response header-parsing macros should become functions)
IMO cleaner pointer arithmetic avoiding unnecessary intermediate slices. No perf gains in isolation but facilitates some (upcoming PRs) This is conceptually easier to reason about, end is fixed, "start" and "cursor" advance monotonically
AaronO
force-pushed
the
refactor/inner-bytes-cursor-arithmetic
branch
from
ae5a1a1
to
de04f3a
Compare
AaronO
added a commit
to AaronO/httparse
that referenced
this pull request
Apr 25, 2023
Builds off seanmonstar#134 (swar), seanmonstar#138 (Bytes cursor) Cleaner, faster and less macros ! - Broke down header-parsing into clean conceptual steps (whilst being faster !) - Added InnerResult allowing for idiomatic `?` early-exits, removing need for parsing-helper macros - Removed macros.rs, leaving only `byte_map!` (response header-parsing macros should become functions)
seanmonstar
reviewed
Apr 25, 2023
seanmonstar
approved these changes
Apr 25, 2023
AaronO
added a commit
to AaronO/httparse
that referenced
this pull request
Apr 25, 2023
Builds off seanmonstar#134 (swar), seanmonstar#138 (Bytes cursor) Cleaner, faster and less macros ! - Broke down header-parsing into clean conceptual steps (whilst being faster !) - Added InnerResult allowing for idiomatic `?` early-exits, removing need for parsing-helper macros - Removed macros.rs, leaving only `byte_map!` (response header-parsing macros should become functions)
AaronO
added a commit
to AaronO/httparse
that referenced
this pull request
Jun 1, 2023
Builds off seanmonstar#134 (swar), seanmonstar#138 (Bytes cursor) Cleaner, faster and less macros ! - Broke down header-parsing into clean conceptual steps (whilst being faster !) - Added InnerResult allowing for idiomatic `?` early-exits, removing need for parsing-helper macros - Removed macros.rs, leaving only `byte_map!` (response header-parsing macros should become functions)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IMO cleaner pointer arithmetic avoiding unnecessary intermediate slices.
No perf gains in isolation but facilitates some (upcoming PRs)
This is conceptually easier to reason about, end is fixed, "start" and "cursor" advance monotonically