Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enabled the use of clippy for the project. #144

Merged
merged 1 commit into from
Jun 12, 2023

Commits on Jun 12, 2023

  1. Enabled the use of clippy for the project.

    * Run clippy in CI
        - Require SAFETY documents in front of every unsafe block.
        - Set MSRV version in clippy.toml to avoid lints that break the MSRV
    * Several fixes to make clippy happy
        - Ran cargo clippy --fix
        - Added some clippy exceptions
        - Added many SAFETY comments to unsafe blocks
    * Tested MIRAI static analyzer to find "unintentional panics"
        - added some debug-build overflow checks to satsify MIRAI
        - Currently, installing MIRAI takes way too long in CI so it is
          disabled for now. Need to find a way to cache this.
    
    Signed-off-by: Michael Rodler <mrodler@amazon.de>
    Michael Rodler committed Jun 12, 2023
    Configuration menu
    Copy the full SHA
    c277612 View commit details
    Browse the repository at this point in the history