Change default tcp_keepalive value to be disabled (#1113)

seanmonstar · Dec 14, 2020 · 46efd05 · 46efd05
1 parent 3ca0bd9
commit 46efd05
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 5 deletions.
diff --git a/src/async_impl/client.rs b/src/async_impl/client.rs
@@ -136,7 +136,9 @@ impl ClientBuilder {
                 connection_verbose: false,
                 pool_idle_timeout: Some(Duration::from_secs(90)),
                 pool_max_idle_per_host: std::usize::MAX,
-                tcp_keepalive: Some(Duration::from_secs(60)),
+                // TODO: Re-enable default duration once hyper's HttpConnector is fixed
+                // to no longer error when an option fails.
+                tcp_keepalive: None, //Some(Duration::from_secs(60)),
                 proxies: Vec::new(),
                 auto_sys_proxy: true,
                 redirect_policy: redirect::Policy::default(),
@@ -730,8 +732,6 @@ impl ClientBuilder {
     /// Set that all sockets have `SO_KEEPALIVE` set with the supplied duration.
     ///
     /// If `None`, the option will not be set.
-    ///
-    /// Default is 60 seconds.
     pub fn tcp_keepalive<D>(mut self, val: D) -> ClientBuilder
         where
             D: Into<Option<Duration>>,

diff --git a/src/blocking/client.rs b/src/blocking/client.rs
@@ -412,8 +412,6 @@ impl ClientBuilder {
     /// Set that all sockets have `SO_KEEPALIVE` set with the supplied duration.
     ///
     /// If `None`, the option will not be set.
-    ///
-    /// Default is 60 seconds.
     pub fn tcp_keepalive<D>(self, val: D) -> ClientBuilder
         where
             D: Into<Option<Duration>>,