[#1095]: Implement basic_auth for WASM
#1096
Conversation
|
Hi @seanmonstar, can this PR be merged? Having basic_auth on x86 but not wasm is just a pointless paper cut. |
|
I painfully ran into this today. Can this please be merged? @seanmonstar |
|
@ctron It says it has merge conflicts, would it be possible to resolve please? |
ctron
force-pushed
the
feature/basic_auth_wasm_1
branch
from
48ec60b
to
97c1c3b
Compare
Signed-off-by: Jens Reimann <jreimann@redhat.com>
ctron
force-pushed
the
feature/basic_auth_wasm_1
branch
from
97c1c3b
to
e2de93c
Compare
Should be done. |
There was a problem hiding this comment.
I can confirm this PR works as expected. cc/ @seanmonstar
Running against latest release, my software fails to compile with Trunk or (cargo build --target wasm32-unknown-unkown). But running against this branch, Trunk successfully compiles.
Implements Basic Authentication to authenticate requests against GitHub's API. Uses the [`http-auth-basic`][1] crate to create a HTTP header value for `Authorization` header using environment variables. This approach is likely to be replaced by using the: `reqwest::RequestBuilder::basic_auth` method which is [a wip][2]. [1]: https://crates.io/crates/http-auth-basic [2]: seanmonstar/reqwest#1096
Implements Basic Authentication to authenticate requests against GitHub's API. Uses the [`http-auth-basic`][1] crate to create a HTTP header value for `Authorization` header using environment variables. This approach is likely to be replaced by using the: `reqwest::RequestBuilder::basic_auth` method which is [a wip][2]. [1]: https://crates.io/crates/http-auth-basic [2]: seanmonstar/reqwest#1096
Implements Basic Authentication to authenticate requests against GitHub's API. Uses the [`http-auth-basic`][1] crate to create a HTTP header value for `Authorization` header using environment variables. This approach is likely to be replaced by using the: `reqwest::RequestBuilder::basic_auth` method which is [a wip][2]. [1]: https://crates.io/crates/http-auth-basic [2]: seanmonstar/reqwest#1096
|
Not sure why this doesn't get merged. Some feedback on that would be nice @seanmonstar In the meantime, I crated an The downside is that dependent crates, like |
|
Painfully hit this today. Please merge. |
|
Sorry the radio silence, and thanks for constantly reminding me, hopefully this should help a lot of people <3 |
No description provided.