Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: migrate edition 2018 to 2021 #2023

Merged
merged 1 commit into from
Feb 3, 2024
Merged

chore: migrate edition 2018 to 2021 #2023

merged 1 commit into from
Feb 3, 2024

Conversation

nyurik
Copy link
Contributor

@nyurik nyurik commented Nov 9, 2023 •
edited

  • Bump edition to 2021 on both crates
  • Fix docs to use Box<dyn ...> (required)

P.S. So sad I missed the PR 2021 - would be symbolic to have edition 2021 migration as PR number 2021 :)

@nyurik nyurik mentioned this pull request Nov 9, 2023
Merged
@seanmonstar
Copy link
Owner

Thanks for the PR!

I fully expect that removing all these "features" will cause breakage for anyone who included them unwittingly. And I don't think there'd be a great improvement for them to go through the breakage.

I do think it'd be great when we mean to do a breaking release...

@nyurik
Copy link
Contributor Author

nyurik commented Nov 9, 2023

@seanmonstar would you rather have them implicit for now? Would it make sense to search github for all cases of reqwest usage with features, and check if anyone has used them? Because if there are very few users who have actually used unintended features, cleaning up features would reduce the exposed API surface, making the crate less likely to break in in the future.

Secondly, I could split this PR into two - one with features, and the other just the edition stuff.

@nyurik nyurik mentioned this pull request Nov 9, 2023
Merged
@nyurik nyurik changed the title chore: edition 2021, hide internal features chore: edition 2021 Nov 9, 2023
@nyurik
Copy link
Contributor Author

nyurik commented Nov 9, 2023

@seanmonstar I moved non-edition related changes to #2026 , so this PR is only about edition bump

@nyurik nyurik force-pushed the edition2021 branch 2 times, most recently from d0da89f to 5d73687 Compare November 9, 2023 04:39
@nyurik nyurik changed the title chore: edition 2021 chore: migrate edition 2018 to 2021 Nov 9, 2023
@nyurik
Copy link
Contributor Author

nyurik commented Dec 30, 2023

@seanmonstar this is now just an edition bump. Is there anything else i should do to this PR? Thx!

@nyurik
Copy link
Contributor Author

nyurik commented Feb 3, 2024

@seanmonstar I had to rebase this PR - seemed like something got mis-merged. Should be cleaner and simpler now. Let me know if anything else is blocking, thx!

@nyurik nyurik mentioned this pull request Feb 3, 2024
Merged
@nyurik
chore: edition 2021
6525c00 
* Bump edition to 2021 on both crates
* Fix docs to use `Box<dyn ...>` (required)
* minor spacing cleanup
@seanmonstar seanmonstar merged commit 05996d8 into seanmonstar:master Feb 3, 2024
31 checks passed
@seanmonstar
Copy link
Owner

Thanks so much!

@nyurik nyurik deleted the edition2021 branch February 3, 2024 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@nyurik @seanmonstar