Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify correct specification of dependency on serde #525

Merged
merged 2 commits into from May 16, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion Cargo.toml
Expand Up @@ -52,7 +52,7 @@ time = "0.1.42"

[dev-dependencies]
env_logger = "0.6"
serde_derive = "1.0"
serde = { version = "1.0", features = ["derive"] }
tokio-tcp = "0.1"
libflate = "0.1"
doc-comment = "0.3"
Expand Down
2 changes: 1 addition & 1 deletion examples/async_multiple_requests.rs
Expand Up @@ -4,11 +4,11 @@ extern crate futures;
extern crate reqwest;
extern crate tokio;
extern crate serde;
#[macro_use] extern crate serde_derive;
extern crate serde_json;

use futures::Future;
use reqwest::async::{Client, Response};
use serde::Deserialize;

#[derive(Deserialize, Debug)]
struct Slideshow {
Expand Down
4 changes: 3 additions & 1 deletion examples/json_typed.rs
Expand Up @@ -4,9 +4,11 @@
//! Rust compile-time type system guaranties though it requires a little bit
//! more code.
extern crate reqwest;
#[macro_use] extern crate serde_derive;
extern crate serde;
extern crate serde_json;

use serde::{Deserialize, Serialize};

#[derive(Debug, Serialize, Deserialize)]
struct Post {
id: Option<i32>,
Expand Down
1 change: 1 addition & 0 deletions src/async_impl/request.rs
Expand Up @@ -428,6 +428,7 @@ pub(crate) fn replace_headers(dst: &mut HeaderMap, src: HeaderMap) {
mod tests {
use super::Client;
use std::collections::BTreeMap;
use serde::Serialize;

#[test]
fn add_query_append() {
Expand Down
5 changes: 3 additions & 2 deletions src/error.rs
Expand Up @@ -9,10 +9,11 @@ use {StatusCode, Url};
/// # Examples
///
/// ```
/// #[macro_use]
/// extern crate serde_derive;
/// extern crate serde;
/// extern crate reqwest;
///
/// use serde::Deserialize;
///
/// #[derive(Deserialize)]
/// struct Simple {
/// key: String
Expand Down
3 changes: 0 additions & 3 deletions src/lib.rs
Expand Up @@ -193,9 +193,6 @@ extern crate mime_guess;
#[cfg(feature = "default-tls")]
extern crate native_tls;
extern crate serde;
#[cfg(test)]
#[macro_use]
extern crate serde_derive;
extern crate serde_json;
extern crate serde_urlencoded;
extern crate time;
Expand Down
1 change: 1 addition & 0 deletions src/request.rs
Expand Up @@ -582,6 +582,7 @@ mod tests {
use {body, Client, Method};
use header::{ACCEPT, HOST, HeaderMap, HeaderValue, CONTENT_TYPE};
use std::collections::{BTreeMap, HashMap};
use serde::Serialize;
use serde_json;
use serde_urlencoded;

Expand Down
3 changes: 2 additions & 1 deletion src/response.rs
Expand Up @@ -186,9 +186,10 @@ impl Response {
///
/// ```rust
/// # extern crate reqwest;
/// # #[macro_use] extern crate serde_derive;
/// # extern crate serde;
/// #
/// # use reqwest::Error;
/// # use serde::Deserialize;
/// #
/// #[derive(Deserialize)]
/// struct Ip {
Expand Down