Update to async/await #617
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seanmonstar
force-pushed
the
async-await
branch
from
5b6cc66
to
60b548e
Compare
|
Bleck, none of the merge strategies are seeming to work, I'll just resolve manually. |
seanmonstar
force-pushed
the
async-await
branch
3 times, most recently
from
91410a5
to
56271fc
Compare
5 tasks
|
One thing I've noticed before, why deny warnings? Warnings can be added to defaults in editions, so there's no guarantee this code would compile in Rust 2021. |
seanmonstar
force-pushed
the
async-await
branch
3 times, most recently
from
d100233
to
825d838
Compare
seanmonstar
force-pushed
the
async-await
branch
from
825d838
to
39bff6e
Compare
Co-authored-by: Danny Browning <danny.browning@protectwise.com> Co-authored-by: Daniel Eades <danieleades@hotmail.com>
seanmonstar
force-pushed
the
async-await
branch
from
39bff6e
to
e916740
Compare
To make sure all warnings are addressed while developing the library. As a dependency, cargo caps the lints so that the deny won't stop compiling. |
This was referenced Sep 7, 2019
Closed
|
Ah, didn't realize that cargo limits it when used as a dependency. In that case, do whatever you want 😆 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates reqwest from futures 0.1 to
std::future::Future, and usesasync/awaitsyntax. This is a rebase and update of #592Some features had to be temporarily disabled until the related dependencies upgrade as well:
Closes #565