-
-
Notifications
You must be signed in to change notification settings - Fork 709
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Filter::or with a filter's error of Never should also have Never as error #109
Milestone
Comments
seanmonstar
added a commit
that referenced
this issue
Jan 31, 2019
seanmonstar
added a commit
that referenced
this issue
Feb 1, 2019
seanmonstar
added a commit
that referenced
this issue
Feb 1, 2019
seanmonstar
added a commit
that referenced
this issue
Feb 1, 2019
seanmonstar
added a commit
that referenced
this issue
May 3, 2019
seanmonstar
added a commit
that referenced
this issue
May 16, 2019
seanmonstar
added a commit
that referenced
this issue
Nov 12, 2019
seanmonstar
added a commit
that referenced
this issue
Nov 12, 2019
masonforest
pushed a commit
to masonforest/warp
that referenced
this issue
Dec 20, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
If you chain 2 filters with an
or
, and the latter one can never fail, it is clear that the chained filter likewise can never fail. However, this is currently not true:It should be like this:
I've made changes locally that makes this work, by modifying
CombineRejection
, but I suspect this change may subtly break some people...The text was updated successfully, but these errors were encountered: