Replace unmaintained/outdated github actions #1020
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The toolchain is now installed with `dtolnay/rust-toolchain`.
|
Hi, and thanks for this! |
|
I think we can solve this by changing the types to |
brotskydotcom
added a commit
to brotskydotcom/warp
that referenced
this pull request
Feb 18, 2023
This fixes the new compiler warning about implicit associated type bounds, as per seanmonstar#1020 (comment)
clickonetwo
added a commit
to clickonetwo/adobe-desktop-licensing-utilities
that referenced
this pull request
Feb 18, 2023
1. Don't take references of Strings unless their needed. 2. Use explicit tuple with Extract = impl Reply type, as per seanmonstar/warp#1020 (comment), to avoid warnings about implicit attributed bounds.
This indeed makes the warp examples compile. Any plans to merge these modifications? |
would you like to submit a PR addressing that? :) |
baum
added a commit
to baum/warp
that referenced
this pull request
Mar 20, 2023
- Per Sean McArthur's suggestion here - seanmonstar#1020 (comment) - Fixes seanmonstar#1015
baum
added a commit
to baum/warp
that referenced
this pull request
Mar 20, 2023
- Per Sean McArthur's suggestion here - seanmonstar#1020 (comment) - Fixes seanmonstar#1015
seanmonstar
pushed a commit
that referenced
this pull request
Mar 20, 2023
- Per Sean McArthur's suggestion here - #1020 (comment) - Fixes #1015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The toolchain is now installed with
dtolnay/rust-toolchain.