[PoC] [RFC] Allow routes to return anyhow::Error #588
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using anyhow allows for really ergonomic error handling in Rust code. Unfortunately, these ergonomics end at the integration layer with warp. Currently, we work around this by having separate handler functions that return an
anyhow::Result
which we then pack into a rejection (we also have an intermediary step forHttpApiProblem
but that is not important at this stage):https://github.com/comit-network/comit-rs/blob/301eb63afea6327df8eb7281bc8251090cc120a3/cnd/src/http_api/routes.rs#L30-L37
I am putting this PR up as a proof-of-concept to show that we could improve ergonomics here fairly easily :)
I wasn't quite sure how to deal with the
CombineRejection
trait. The compiler complained so I implemented it in a way that seems to work but I feel that this was not the original purpose of it.