Upgrade tokio-tungstenite to 0.15 #883
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, thanks for maintaining this great project!
The tokio-tungstenite library was recently updated to version 0.15 which includes some performance improvements over version 0.14. In my test setup, which uses "websocat" to send messages to the bundled example echo-server ("examples/websocket.rs"), the throughput with version 0.15 is improved from about 60 MB/s to 80MB/s with a single connection.
Using several parallel connections maxes out the network bandwidth so the total transfer time is about the same, but the CPU load on the server is consistently lower (~50% CPU idle according to "top" with tokio-tungstenite 0.15, compared to ~35% idle with version 0.14). The echo-server was run on a Raspberry Pi 4 with the standard Raspberry Pi OS.
I thought it might be worthwhile to update to this new version, unless there are other reasons for why it might not be desirable.
Please let me know what you think.