Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Miscelaneous fixes and changes #5

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Conversation

Kableado
Copy link

These are the changes and corrections that I have been making while using this very useful tool.

I make this PR so you can use my changes if they are useful to you.

I will delete this fork after solving this PR (whether accepted or rejected).

Thank you very much for your work!

@seanofw
Copy link
Owner

seanofw commented Apr 18, 2023

These changes are otherwise fine, but some of them result in unnecessary diffs because the original code uses tabs, not spaces. If you go through this PR and update it to use tabs instead, I can merge it.

We should also update its README, though, to indicate that it's now built for .NET Framework 4.x, not for .NET Framework 3.x anymore, and the new code won't work with .NET Framework 3.x. Anyone still on .NET Framework has likely upgraded, but it's probably worth noting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants