Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use to_prepare for autoloading to support Rails 7 #14

Merged
merged 1 commit into from
Feb 18, 2022

Conversation

tricknotes
Copy link
Contributor

In Rails 7, previous code raises a NameError.

/bundle/ruby/3.0.0/gems/ember-cli-rails-assets-0.6.2/lib/ember_cli/assets/engine.rb:5:in `block in <class:Engine>': uninitialized constant EmberCli::Assets::Engine::EmberCliRailsAssetsHelper (NameError)

Using to_prepare is recommended to use autoload since Rails 7.
rails/rails@dc047f7

In Rails 7, previous code raises a NameError.
```
/bundle/ruby/3.0.0/gems/ember-cli-rails-assets-0.6.2/lib/ember_cli/assets/engine.rb:5:in `block in <class:Engine>': uninitialized constant EmberCli::Assets::Engine::EmberCliRailsAssetsHelper (NameError)
```

Using `to_prepare` is recommended to use autoload since Rails 7.
rails/rails@dc047f7
@tricknotes
Copy link
Contributor Author

It seems CI doesn't run on this repository.
I' interested in #13 👀

@tricknotes tricknotes changed the title Use to_prepare to use autoload inside engine config to support Rails 7 Use to_prepare for autoloading to support Rails 7 Dec 17, 2021
@seanpdoyle seanpdoyle merged commit 80b9fff into seanpdoyle:master Feb 18, 2022
@tricknotes tricknotes deleted the rails-7 branch February 27, 2022 07:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants