Add base_path option to include asset methods

[jboler]

Ignore previous comments - I got the specs working after looking at the travis config.

[houndci-bot]

Surrounding space missing in default value assignment.

[houndci-bot]

Line is too long. [85/80]

[jboler]

@seanpdoyle Is there any chance this could be merged?

[franzliedke]

Yes, please! I wish it would do this automatically, but at least this gives me a way to fix the base URL problem. :)

[seanpdoyle]

@jboler thanks for opening this pull request -- sorry for the delay!

I'm sorry, but I don't understand the current implementation doesn't work for you -- would you mind explaining how it doesn't support your use case?

cc: @franzliedke

[franzliedke]

It's a path relative to the current URL, not the site's base URL.

[seanpdoyle]

@franzliedke I understand the new functionality, but I don't understand the use case.

Given the following situations:

• viewing a "/" page, with assets served from your server, browsers will resolve vendor.js to /vendor.js
• viewing a "/child" page, with assets served from your server, browsers will resolve vendor.js to /child/vendor.js
• viewing a "/child" page, with assets served from a CDN, ember-cli-build.js configured to prepend the CDN host, and a <base href="/child"> element, browsers will resolve vendor.js to https://cdn.example.com/child/vendor.js

In what ways do your use cases not fit into one of those scenarios?

[jboler]

See my issue: #6

[franzliedke]

Huh? How does that help me when I render the ember_script_tags both on /foo/ and on /foo/bar/?

[seanpdoyle]

@jboler thanks for the clarification -- I understand now.

Instead of extending this gem to further monkey with the EmberCLI-generated URLs, would you be able to achieve the same thing by prepending asset URLs with the absolute path during EmberCLI's asset compilation?

[seanpdoyle]

@franzliedke thanks for mentioning that you're rendering script tags on both /foo/ and /foo/bar/.

Could you please elaborate further on how you're trying to use the gam, and the ways in which the current implementation falls short so that I can better understand your problem and possibly offer an alternative solution?

[jboler]

@seanpdoyle I can't do that during asset compilation because (as noted in the issue) the <base> tag breaks SVG <def> paths & <a> anchor paths. Basically I think the <base> tag is being used incorrectly with ember-cli-rails-assets because it is applied to every URL on the page when there are lots of valid use cases where one doesn't want this to happen.

Also, my Rails app has many different URLs where I need the same Ember app to load so I need include_ember_script_tags() to be able produce an absolute URL.

[seanpdoyle]

Merged in 23f9425.

Thanks!

[skylar]

@seanpdoyle We had poltergeist/capybara-based test that were failing using the <base> tag method, and it was holding up our migration to ember-cli 2.3 and your awesome updates on ember-cli-rails. As I was starting to write the same patch, we found and pulled this PR which made the build green.

Looking forward to a new gem version published with this fix. Thanks for supporting this project for the community!

[seanpdoyle]

@skylar @jboler this is part of the 0.6.2 release.

[skylar]

@seanpdoyle thanks! 👍