Add missing support for date_select method.
#13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this commit, a corresponding implementation for [ActionView::Helpers::FormBuilder#date_select][date_select] was omitted. This commit corrects that oversight. [date_select]: https://api.rubyonrails.org/classes/ActionView/Helpers/FormBuilder.html#method-i-date_select
seanpdoyle
added a commit
that referenced
this pull request
Aug 6, 2020
One major drawback to the original `ViewPartialFormBuilder::FormBuilder` implementation was its obligation to totally re-create the underlying `FormBuilder` behavior, including minor implementation details like calling `objectify_options` and setting and unsetting instance variables like `@emitted_hidden_id = true if method == :id`. Another drawback is that if the method wasn't declared, there would be no means of declaring a corresponding view partial. This is exactly what happened with the `date_select` helper (fixed in [#13][]). This new implementation proxies calls to render ActionView instances through the `ViewPartialFormBuilder::TemplateProxy`, which first attempts to resolve a view partial that matches the method call. It is not without its quirks. For example, the `#button` and `#submit` methods are special case, because they invoke a method on the `@template` that is suffixed with `_tag`. Additionally, the `#label` helper is a special case because of the optional nature of the `text = nil` parameter. [#13]: #13
seanpdoyle
added a commit
that referenced
this pull request
Aug 6, 2020
One major drawback to the original `ViewPartialFormBuilder::FormBuilder` implementation was its obligation to totally re-create the underlying `FormBuilder` behavior, including minor implementation details like calling `objectify_options` and setting and unsetting instance variables like `@emitted_hidden_id = true if method == :id`. Another drawback is that if the method wasn't declared, there would be no means of declaring a corresponding view partial. This is exactly what happened with the `date_select` helper (fixed in [#13][]). This new implementation proxies calls to render ActionView instances through the `ViewPartialFormBuilder::TemplateProxy`, which first attempts to resolve a view partial that matches the method call. It is not without its quirks. For example, the `#button` and `#submit` methods are special case, because they invoke a method on the `@template` that is suffixed with `_tag`. Additionally, the `#label` helper is a special case because of the optional nature of the `text = nil` parameter. [#13]: #13
seanpdoyle
added a commit
that referenced
this pull request
Jan 22, 2023
One major drawback to the original `ViewPartialFormBuilder::FormBuilder` implementation was its obligation to totally re-create the underlying `FormBuilder` behavior, including minor implementation details like calling `objectify_options` and setting and unsetting instance variables like `@emitted_hidden_id = true if method == :id`. Another drawback is that if the method wasn't declared, there would be no means of declaring a corresponding view partial. This is exactly what happened with the `date_select` helper (fixed in [#13][]). This new implementation proxies calls to render ActionView instances through the `ViewPartialFormBuilder::TemplateProxy`, which first attempts to resolve a view partial that matches the method call. It is not without its quirks. For example, the `#button` and `#submit` methods are special case, because they invoke a method on the `@template` that is suffixed with `_tag`. Additionally, the `#label` helper is a special case because of the optional nature of the `text = nil` parameter. [#13]: #13
seanpdoyle
added a commit
that referenced
this pull request
Jan 22, 2023
One major drawback to the original `ViewPartialFormBuilder::FormBuilder` implementation was its obligation to totally re-create the underlying `FormBuilder` behavior, including minor implementation details like calling `objectify_options` and setting and unsetting instance variables like `@emitted_hidden_id = true if method == :id`. Another drawback is that if the method wasn't declared, there would be no means of declaring a corresponding view partial. This is exactly what happened with the `date_select` helper (fixed in [#13][]). This new implementation proxies calls to render ActionView instances through the `ViewPartialFormBuilder::TemplateProxy`, which first attempts to resolve a view partial that matches the method call. It is not without its quirks. For example, the `#button` and `#submit` methods are special case, because they invoke a method on the `@template` that is suffixed with `_tag`. Additionally, the `#label` helper is a special case because of the optional nature of the `text = nil` parameter. [#13]: #13
seanpdoyle
added a commit
that referenced
this pull request
Jan 22, 2023
One major drawback to the original `ViewPartialFormBuilder::FormBuilder` implementation was its obligation to totally re-create the underlying `FormBuilder` behavior, including minor implementation details like calling `objectify_options` and setting and unsetting instance variables like `@emitted_hidden_id = true if method == :id`. Another drawback is that if the method wasn't declared, there would be no means of declaring a corresponding view partial. This is exactly what happened with the `date_select` helper (fixed in [#13][]). This new implementation proxies calls to render ActionView instances through the `ViewPartialFormBuilder::TemplateProxy`, which first attempts to resolve a view partial that matches the method call. It is not without its quirks. For example, the `#button` and `#submit` methods are special case, because they invoke a method on the `@template` that is suffixed with `_tag`. Additionally, the `#label` helper is a special case because of the optional nature of the `text = nil` parameter. [#13]: #13
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this commit, a corresponding implementation for
ActionView::Helpers::FormBuilder#date_select was omitted.
This commit corrects that oversight.