Fix undeclared var warning #14
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR @madstap ! Will look at it in more details later today! |
|
The missing |
|
Hey @madstap what's the story with all these XML files ? Maybe you want to take them out of the PR? And maybe you can summarise what this PR is meant to do? Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was getting this warning
WARNING: Use of undeclared Var cljs-react-navigation.re-frame/addNavigationHelpers at line 82 target/expo/cljs_react_navigation/re_frame.cljs. This fixes that.Something was probably broken, functionality-wise, but I'm still figuring out this library so I don't really know what.