Merge pull request #47 from seantis/issue_45

Issue 45
seantis · Oct 8, 2015 · 2021b9c · 2021b9c
2 parents 459f5c4 + 6e2de84
commit 2021b9c
Show file tree

Hide file tree

Showing 6 changed files with 39 additions and 2 deletions.
diff --git a/docs/HISTORY.rst b/docs/HISTORY.rst
@@ -5,12 +5,14 @@ Changelog
 0.32 (unreleased)
 ~~~~~~~~~~~~~~~~~
 
-Nothing yet.
+- Update the catalog after renaming a person #45.
+  [msom]
 
 0.31 (2015-05-03)
 ~~~~~~~~~~~~~~~~~
 
 - Fix an error in ZodbMembershipSource #44.
+  [msom]
 
 0.30 (2015-04-09)
 ~~~~~~~~~~~~~~~~~

diff --git a/seantis/people/behaviors/name_from_person.py b/seantis/people/behaviors/name_from_person.py
@@ -14,6 +14,7 @@ def on_object_modified(obj, event=None):
     """
 
     obj.setTitle(get_name_from_person(obj))
+    obj.reindexObject()
 
 
 def get_name_from_person(obj):

diff --git a/seantis/people/profiles/default/metadata.xml b/seantis/people/profiles/default/metadata.xml
@@ -1,5 +1,5 @@
 <metadata>
-    <version>1012</version>
+    <version>1013</version>
     <dependencies>
         <dependency>profile-plone.app.dexterity:default</dependency>
         <dependency>profile-collective.js.underscore:default</dependency>

diff --git a/seantis/people/tests/test_browser.py b/seantis/people/tests/test_browser.py
@@ -85,3 +85,27 @@ def test_remove_from_list(self):
         browser.open(list_url)
         self.assertNotIn('Claire', browser.contents)
         self.assertNotIn('Dunphy', browser.contents)
+
+    def test_rename_person(self):
+        list_url = self.new_people_list()
+        self.new_person('Claire', 'Dunphy')
+
+        browser = self.new_admin_browser()
+
+        browser.open(list_url)
+        self.assertIn('Dunphy', browser.contents)
+        browser.open(self.baseurl + '/@@search?SearchableText=Dunphy')
+        self.assertIn('Claire', browser.contents)
+        browser.open(self.baseurl + '/@@search?SearchableText=Griffin')
+        self.assertIn('No results were found', browser.contents)
+
+        browser.open(list_url + '/dunphy-claire/edit')
+        browser.getControl('Last Name').value = 'Griffin'
+        browser.getControl('Save').click()
+
+        browser.open(list_url)
+        self.assertIn('Griffin', browser.contents)
+        browser.open(self.baseurl + '/@@search?SearchableText=Dunphy')
+        self.assertIn('No results were found', browser.contents)
+        browser.open(self.baseurl + '/@@search?SearchableText=Griffin')
+        self.assertIn('Claire', browser.contents)
diff --git a/seantis/people/upgrades.py b/seantis/people/upgrades.py
@@ -118,3 +118,6 @@ def enable_referenceablebehavior(context):
 def reindex_members(context):
     catalog = api.portal.get_tool(catalog_id)
     catalog.refreshCatalog(clear=1)
+
+    catalog = api.portal.get_tool('portal_catalog')
+    catalog.refreshCatalog(clear=1)
diff --git a/seantis/people/upgrades.zcml b/seantis/people/upgrades.zcml
@@ -86,6 +86,13 @@
         handler=".upgrades.reindex_members"
     />
 
+    <genericsetup:upgradeStep
+        title="Reindex members."
+        source="1012" destination="1013"
+        profile="seantis.people:default"
+        handler=".upgrades.reindex_members"
+    />
+
     <!-- PHZ Upgrades -->
     <genericsetup:upgradeStep
         title="Remove import action from detail view."