Skip to content

Commit

Permalink
fix: remove typing_extensions dependencies
Browse files Browse the repository at this point in the history
Fix #299
  • Loading branch information
seanwu1105 committed Apr 7, 2023
1 parent 03a1dc4 commit e694a55
Show file tree
Hide file tree
Showing 4 changed files with 4 additions and 13 deletions.
4 changes: 2 additions & 2 deletions python/poetry.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 0 additions & 1 deletion python/pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,6 @@ pyside6 = "^6.4.2"
pyqt6 = "^6.4.0"
pyside2 = { version = "^5.15.2.1", markers = "sys_platform != 'darwin' or platform_machine != 'arm64'" }
pyqt5 = { version = "^5.15.7", markers = "sys_platform != 'darwin' or platform_machine != 'arm64'" }
typing-extensions = "^4.5.0"

[tool.poetry.group.dev.dependencies]
pylint = "^2.14.5"
Expand Down
6 changes: 1 addition & 5 deletions python/scripts/utils/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -3,13 +3,9 @@
import sys
import typing

import typing_extensions # Remove after dropping Python 3.7

QT_DEPENDENCY_ARG = "vscode_extension_qt_dependency"

SupportedQtDependencies = typing.Optional[
typing_extensions.Literal["PySide6", "PySide2", "PyQt6", "PyQt5"]
]
SupportedQtDependencies = typing.Optional[str]


def is_installed(name: str) -> bool:
Expand Down
6 changes: 1 addition & 5 deletions python/tests/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,6 @@
import subprocess
import typing

import typing_extensions

from scripts.utils import QT_DEPENDENCY_ARG, SupportedQtDependencies

TESTS_DIR = os.path.dirname(os.path.realpath(__file__))
Expand All @@ -13,9 +11,7 @@

ASSETS_DIR = os.path.join(TESTS_DIR, "assets")

SupportedScripts = typing_extensions.Literal[
"designer", "qml", "qmlls", "rcc", "uic", "lupdate", "linguist", "lrelease"
]
SupportedScripts = typing.Type[str]


def filter_available_qt_dependencies(
Expand Down

0 comments on commit e694a55

Please sign in to comment.