Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix test fail on Ruby 1.9.3 #9

Merged
merged 1 commit into from Sep 16, 2015
Merged

Fix test fail on Ruby 1.9.3 #9

merged 1 commit into from Sep 16, 2015

Conversation

seapagan
Copy link
Owner

'rake' would fail on Ruby 1.9.3 since the 'reek' gem needs Ruby >2.0.
Add conditional dependancy in gemspec and Rakefile to bypass this.

Signed-off-by: Seapagan seapagan@gmail.com

@seapagan
Copy link
Owner Author

PullReview stats

@seapagan
Copy link
Owner Author

PullReview perfect.
Style Favor modifier if/unless usage when you have a single-line body. Another good alternative is the usage of control flow &&/|| confoog.gemspec:35
Style Prefer single quoted strings when you don't need string interpolation or special symbols. Rakefile:18
Style Prefer single quoted strings when you don't need string interpolation or special symbols. confoog.gemspec:35

@seapagan
Fix test fail on Ruby 1.9.3
692dde2 
'rake' would fail on Ruby 1.9.3 since the 'reek' gem needs Ruby >2.0.
Add conditional dependancy in gemspec and Rakefile to bypass this.

Fix style violations

Signed-off-by: Seapagan <seapagan@gmail.com>
seapagan added a commit that referenced this pull request Sep 16, 2015
@seapagan
Merge pull request #9 from seapagan/fix-reek-under-1.9.3
38ceb2f 
Fix test fail on Ruby 1.9.3
@seapagan seapagan merged commit 38ceb2f into master Sep 16, 2015
@seapagan seapagan deleted the fix-reek-under-1.9.3 branch September 16, 2015 05:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@seapagan