Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unit tests #72

Closed
Elia-238 opened this issue May 3, 2023 · 4 comments
Closed

Add unit tests #72

Elia-238 opened this issue May 3, 2023 · 4 comments
Assignees
Labels

Comments

@Elia-238
Copy link

Elia-238 commented May 3, 2023

Please add unit tests so we can check if the project works.

@seapagan seapagan self-assigned this May 3, 2023
@seapagan
Copy link
Owner

seapagan commented May 3, 2023

Definitely 😁!
It's on the roadmap, and I'm slowly adding them to a derivative project of this template at the moment. I'll backport them to this project when that's done.

It will probably be a couple of weeks, realistically.

@seapagan seapagan added the tests label May 3, 2023
@seapagan seapagan mentioned this issue May 29, 2023
@seapagan seapagan pinned this issue May 30, 2023
@seapagan
Copy link
Owner

seapagan commented Jun 2, 2023

I merged PR #84 today.
This brings the coverage up to 80%. A few fixes and refactoring were also involved in this PR that came to light while writing the testing, so I thought it better to merge. The PR also includes a GitHub Action to run the tests on each commit or PR

I'll leave this Issue open until full coverage is reached 👍

@seapagan
Copy link
Owner

@Elia-238 Unless you have any issues Im going to close this PR.

Coverage is up to 98% with both Unit and Integration tests. The last 2% is in the startup connection-testing code and I need to re-write those tests as they are causing other tests to fail (the mock is not being cleared). All the important logic is tested though.

@seapagan
Copy link
Owner

Closing as test coverage is at 98%

@seapagan seapagan unpinned this issue Jun 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants