Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setup Testing #84

Merged
merged 35 commits into from
Jun 2, 2023
Merged

Setup Testing #84

merged 35 commits into from
Jun 2, 2023

Conversation

seapagan
Copy link
Owner

@seapagan seapagan commented May 29, 2023

Work in progress PR to add integration and unit tests to the API as a start to closing Issue #72

This PR will not give total test coverage when merged, but it will be a building block to work upon

Signed-off-by: Grant Ramsay <seapagan@gmail.com>
@seapagan seapagan added enhancement New feature or request tests labels May 29, 2023
@seapagan seapagan self-assigned this May 29, 2023
Signed-off-by: Grant Ramsay <seapagan@gmail.com>
Signed-off-by: Grant Ramsay <seapagan@gmail.com>
sqlalchemy 2 has a lot of changes but the 'databases' async package is
not yet compatible.

Signed-off-by: Grant Ramsay <seapagan@gmail.com>
Signed-off-by: Grant Ramsay <seapagan@gmail.com>
Signed-off-by: Grant Ramsay <seapagan@gmail.com>
Signed-off-by: Grant Ramsay <seapagan@gmail.com>
Signed-off-by: Grant Ramsay <seapagan@gmail.com>
Signed-off-by: Grant Ramsay <seapagan@gmail.com>
Signed-off-by: Grant Ramsay <seapagan@gmail.com>
@codecov
Copy link

codecov bot commented May 30, 2023

Codecov Report

❗ No coverage uploaded for pull request base (main@242898b). Click here to learn what that means.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main      #84   +/-   ##
=======================================
  Coverage        ?   80.57%           
=======================================
  Files           ?       22           
  Lines           ?      520           
  Branches        ?        0           
=======================================
  Hits            ?      419           
  Misses          ?      101           
  Partials        ?        0           

Signed-off-by: Grant Ramsay <seapagan@gmail.com>
Signed-off-by: Grant Ramsay <seapagan@gmail.com>
Signed-off-by: Grant Ramsay <seapagan@gmail.com>
Signed-off-by: Grant Ramsay <seapagan@gmail.com>
Signed-off-by: Grant Ramsay <seapagan@gmail.com>
Signed-off-by: Grant Ramsay <seapagan@gmail.com>
Signed-off-by: Grant Ramsay <seapagan@gmail.com>
Signed-off-by: Grant Ramsay <seapagan@gmail.com>
ignore migrations when checking

Signed-off-by: Grant Ramsay <seapagan@gmail.com>
Signed-off-by: Grant Ramsay <seapagan@gmail.com>
Signed-off-by: Grant Ramsay <seapagan@gmail.com>
Signed-off-by: Grant Ramsay <seapagan@gmail.com>
the token would not work, but better to make it obvious from the start

Signed-off-by: Grant Ramsay <seapagan@gmail.com>
Signed-off-by: Grant Ramsay <seapagan@gmail.com>
Signed-off-by: Grant Ramsay <seapagan@gmail.com>
Hopefully 🤷‍♂️

Signed-off-by: Grant Ramsay <seapagan@gmail.com>
seapagan and others added 9 commits June 1, 2023 18:56
Signed-off-by: Grant Ramsay <seapagan@gmail.com>
Currently commented out until sort async crash

Signed-off-by: Grant Ramsay <seapagan@gmail.com>
'test_create_duplicate_user'

Signed-off-by: Grant Ramsay <seapagan@gmail.com>
Signed-off-by: Grant Ramsay <seapagan@gmail.com>
Otherwise the original can get modified and cause issues with testing

Signed-off-by: Grant Ramsay <seapagan@gmail.com>
Signed-off-by: Grant Ramsay <seapagan@gmail.com>
Signed-off-by: Grant Ramsay <seapagan@gmail.com>
Signed-off-by: Grant Ramsay <seapagan@gmail.com>
@seapagan
Copy link
Owner Author

seapagan commented Jun 2, 2023

At this PR state, we have 80% test coverage (a combination of Unit and Integration tests). I'm going to merge this to use as a baseline and also because several fixes or refactors were included in this PR that came to light when writing tests.

Further tests will be added very soon.

I will leave Issue #72 open for now.

@seapagan seapagan marked this pull request as ready for review June 2, 2023 12:17
@seapagan seapagan merged commit 22d480e into main Jun 2, 2023
10 checks passed
@seapagan seapagan deleted the add_tests branch June 2, 2023 12:17
@seapagan seapagan mentioned this pull request Jun 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant