Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some bugs in the template files and update obsolete information #325

Merged
merged 3 commits into from Mar 13, 2024

Conversation

seapagan
Copy link
Owner

@seapagan seapagan commented Mar 13, 2024

  • The README for the generated project still mentions flake8, black, etc, in the Task Runner and Linting sections. These have all been replaced by ruff.
  • .pre-commit-config.yaml needs tool versions updating.
  • The license name is missing in the generated pyproject.toml

Signed-off-by: Grant Ramsay <seapagan@gmail.com>
Signed-off-by: Grant Ramsay <seapagan@gmail.com>
@seapagan seapagan added the bug Something isn't working label Mar 13, 2024
@seapagan seapagan self-assigned this Mar 13, 2024
Copy link

codacy-production bot commented Mar 13, 2024

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.00% (target: -1.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (f67f234) 582 198 34.02%
Head commit (0995275) 582 (+0) 198 (+0) 34.02% (+0.00%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#325) 0 0 ∅ (not applicable)

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

You may notice some variations in coverage metrics with the latest Coverage engine update. For more details, visit the documentation

@seapagan seapagan changed the title Update template files Fix some bugs in the template files and update obsolete information Mar 13, 2024
Signed-off-by: Grant Ramsay <seapagan@gmail.com>
@seapagan seapagan marked this pull request as ready for review March 13, 2024 10:59
@seapagan seapagan merged commit dfb7dd8 into main Mar 13, 2024
14 checks passed
@seapagan seapagan deleted the update-template branch March 13, 2024 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant